android - if statements possibly not working -

-



i have simple calculator 2 tabs, tabs appear working fine first tab calculating should, calculating second tab keeps throwing catch error.

in 2nd tab, have 2 if statements, checks see edittext field contains data. depending on contains data calculation does.

below code when button pressed have put together, streamlined i'm amature go easy on me.

any advice working please?

calculate.setonclicklistener(             new view.onclicklistener() {                 @override                 public void onclick(view view) {                       if ( tabs.getcurrenttab() == 0) {                          try {                              if (d.gettext().tostring().trim().length() == 0) {                                   a1 = a.gettext().tostring();                                 double a2 = double.parsedouble(a1);                                  b1 = b.gettext().tostring();                                 double b2 = double.parsedouble(b1);                                  double sum = (a2 * b2) / 10000;                                  double total = math.round((sum) * 10) / 10.0;                                  answer.setbackgroundcolor(color.parsecolor("#d6ffffff"));                                 answer.settext(string.valueof("total area allocation = " + total + " ha"));                              } else if (d.gettext().tostring().trim().length() >= 1) {                                  a1 = a.gettext().tostring();                                 double a2 = double.parsedouble(a1);                                  b1 = b.gettext().tostring();                                 double b2 = double.parsedouble(b1);                                   d1 = d.gettext().tostring();                                 double d2 = double.parsedouble(d1);                                   double sum = (a2 * b2) / 10000;                                 double sum2 = (a2 * b2) / d2;                                  double total = math.round((sum) * 10) / 10.0;                                 double total2 = math.round((sum2) * 10) / 10.0;                                  answer.setbackgroundcolor(color.parsecolor("#d6ffffff"));                                 answer.settext(string.valueof("total area allocation = " + total + " ha"));                                 answer2.setbackgroundcolor(color.parsecolor("#d6ffffff"));                                 answer2.settext(string.valueof("set break " + total2 + " m"));                             }                         } catch (exception e) {                             answer.setbackgroundcolor(color.parsecolor("#d6ffffff"));                             answer.settext("enter values in input fields");                         }                     }                      if (tabs.getcurrenttab() == 1) {                          try {                              if (ff.gettext().tostring().trim().length() == 0) {                                   aa1 = aa.gettext().tostring();                                 double aa2 = double.parsedouble(aa1);                                  bb1 = bb.gettext().tostring();                                 double bb2 = double.parsedouble(bb1);                                  cc1 = cc.gettext().tostring();                                 double cc2 = double.parsedouble(cc1);                                  dd1 = dd.gettext().tostring();                                 double dd2 = double.parsedouble(dd1);                                  ee1 = ee.gettext().tostring();                                 double ee2 = double.parsedouble(ee1);                                   if (ee.gettext().tostring().trim().length() == 0){                                      double sum = (aa2 * bb2)/(cc2 - dd2);                                      double total = math.round((sum) * 10) / 10.0;                                      answer.setbackgroundcolor(color.parsecolor("#d6ffffff"));                                     answer.settext(string.valueof("total area allocation = " + total + " ha"));                                  }                                  else if (cc.gettext().tostring().trim().length() == 0){                                      double sum = (aa2 * bb2)/ee2;                                      double total = math.round((sum) * 10) / 10.0;                                      answer.setbackgroundcolor(color.parsecolor("#d6ffffff"));                                     answer.settext(string.valueof("total area allocation = " + total + " ha"));                                  }                               } else if (ff.gettext().tostring().trim().length() >= 1) {                                  aa1 = aa.gettext().tostring();                                 double aa2 = double.parsedouble(aa1);                                  bb1 = bb.gettext().tostring();                                 double bb2 = double.parsedouble(bb1);                                  cc1 = cc.gettext().tostring();                                 double cc2 = double.parsedouble(cc1);                                  dd1 = dd.gettext().tostring();                                 double dd2 = double.parsedouble(dd1);                                  ee1 = ee.gettext().tostring();                                 double ee2 = double.parsedouble(ee1);                                  ff1 = ff.gettext().tostring();                                 double ff2 = double.parsedouble(ff1);                                  if (ee.gettext().tostring().trim().length() == 0){                                      double sum = (aa2*bb2)/(cc2-dd2);                                     double sum2 = (sum * 10000) / ff2;                                      double total = math.round((sum) * 10) / 10.0;                                     double total2 = math.round((sum2) * 10) / 10.0;                                       answer.setbackgroundcolor(color.parsecolor("#d6ffffff"));                                     answer.settext(string.valueof("total area allocation = " + total + " ha"));                                     answer2.setbackgroundcolor(color.parsecolor("#d6ffffff"));                                     answer2.settext(string.valueof("set break " + total2 + " m"));                                  }                                  else if (cc.gettext().tostring().trim().length() == 0){                                      double sum = (aa2 * bb2)/ee2;                                     double sum2 = (sum * 10000) / ff2;                                      double total = math.round((sum) * 10) / 10.0;                                     double total2 = math.round((sum2) * 10) / 10.0;                                      answer.setbackgroundcolor(color.parsecolor("#d6ffffff"));                                     answer.settext(string.valueof("total area allocation = " + total + " ha"));                                     answer2.setbackgroundcolor(color.parsecolor("#d6ffffff"));                                     answer2.settext(string.valueof("set break " + total2 + " m"));                                  }                              }                         } catch (exception e) {                             answer.setbackgroundcolor(color.parsecolor("#d6ffffff"));                             answer.settext("enter values in input fields 2");                         }                       }                 }               });

the catch error

while it's not strictly on topic of why you're running exceptions, might make suggestions improve code , reduce problems down road.

  1. try use more helpful variable names, it's hard know aa , bb are. try explain contain. numofcows or have you.
  2. move logic smaller functions. understand @ glance code does, , other code calls.

for example, create functions handling each tab's calculation, , move logic there.

 calculate.setonclicklistener(             new view.onclicklistener() {                 @override                 public void onclick(view view) {                     if (tabs.getcurrenttab() == 0) {                         calculatefirsttab();                     } else if (tabs.getcurrenttab() == 1) {                         calculatesecondtab();                     }                 }             });
  1. and lastly, try reduce duplication. have lot of code same thing, can make lot cleaner creating small functions help.

for example, here have created function called setanswer lets me pass in textview, , text. let set background color 1 place, , update text. then, creating function called setanswers lets pass in totals, can set both answers that.

private void setanswers( double total1, double total2 ){     setanswer(answer, "total area allocation = " + total1 + " ha");     setanswer(answer2, "set break " + total2 + " m"); }  private void setanswer( textview view, string text  ) {     view.setbackgroundcolor(color.parsecolor("#d6ffffff"));     view.settext(text); }

there lot of other ways improve, suggestions may out.





wiki

Comments

Post a Comment

Popular posts from this blog

python - Read npy file directly from S3 StreamingBody -

-
i have many .npy (numpy) , .json files saved in s3, need download , load these files. for json files downloading files , loading dictionary using following code: obj = s3.object(bucket, key) response = obj.get() body = response['body'].read().decode('utf-8') data = json.loads(body) that way avoid writing .json file disk , reading it. now want same .npy files, equivalent? currently downloading file, saving temp file on disk , loading np.load avoid if possible. following https://stackoverflow.com/a/28196540/3509999 : obj = s3.object(bucket, key) io.bytesio(obj.get()["body"].read()) f: # rewind file f.seek(0) arr = np.load(f) wiki
Read more

python - Minimize function with Scipy minimize -

-
trying obtain d value (integer) std_diff objective function minimal, using scipy minimize. my code: def std_diff(d): return std(diff(df['bn'].values,d)); scipy.optimize import minimize b=(3,) res = minimize(std_diff,(1,), method='slsqp', bounds = b) **df['bn'].values** out[72]: array([ 2, 2, 2, 2, 3, 2, 7, 5, 7, 11, 8, 2, 11, 7, 15, 8, 7, 12, 21, 19, 32, 35, 40, 35, 21, 19, 25, 20, 40, 80, 99], dtype=int64) error is"indexerror: many indices array " in case not use bounds : res = minimize(std_diff,(1,), method='slsqp'), error: > in _minimize_slsqp(func, x0, args, jac, bounds, constraints, maxiter, > ftol, iprint, disp, eps, callback, **unknown_options) > 368 fx = float(np.asarray(func(x))) > 369 except: > --> 370 raise valueerror("objective function must return scalar") > 371 # compute constraints > 3
Read more

kotlin - Out-projected type in generic interface prohibits the use of metod with generic parameter -

-
i start using kotlin , defined interface this: interface aadapter<vh : recyclerview.viewholder> { fun oncreateaviewholder(parent: viewgroup): vh fun onbindaviewholder(v: vh, position: int) } and when try use on code: class klasa ( private val adapter: aadapter<*> ) { fun dosth(){ //... val vh = this.adapter.oncreateaviewholder(parent) //on below line error adapter.onbindaviewholder(v, position) //... } } i error out-projected type 'aadapter<*>' prohibits use of 'public abstract fun onbindaviewholder(v: t, position: int): unit i tied add "in" or "out" definition i'm confused. how allow it. replace aadapter<*> aadapter<recyclerview.viewholder> . class klasa ( private val adapter: aadapter<recyclerview.viewholder> ) { // ... because have declared aadapter has type parameter vh type subclass of recyclerview.
Read more